Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Login for OIDC client #9408

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add Login for OIDC client #9408

merged 1 commit into from
Aug 30, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 19, 2024 •
edited by jira bot
Loading

@sbrunner sbrunner force-pushed the openid-connect-gsggr-152 branch 2 times, most recently from bd3b860 to 9547065 Compare August 20, 2024 10:26
sbrunner
sbrunner commented Aug 20, 2024
View reviewed changes
src/auth/FormElement.ts Outdated Show resolved Hide resolved
@sbrunner sbrunner force-pushed the openid-connect-gsggr-152 branch 6 times, most recently from 29adef4 to 358badc Compare August 21, 2024 14:33
@sbrunner sbrunner marked this pull request as ready for review August 26, 2024 10:32
@sbrunner
Copy link
Member Author

Linked to: camptocamp/c2cgeoportal#11316

ger-benjamin
ger-benjamin reviewed Aug 30, 2024
View reviewed changes
src/auth/FormElement.ts Outdated Show resolved Hide resolved
src/auth/FormElement.ts Outdated Show resolved Hide resolved
@sbrunner sbrunner force-pushed the openid-connect-gsggr-152 branch from 358badc to 62f67a8 Compare August 30, 2024 10:11
ger-benjamin
ger-benjamin approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sbrunner sbrunner merged commit d229559 into master Aug 30, 2024
13 checks passed
@sbrunner sbrunner deleted the openid-connect-gsggr-152 branch August 30, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@llienher llienher Awaiting requested review from llienher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @ger-benjamin